Adding possibility to include Authorization header when using externa… #7596
Conversation
code-asher
left a comment
code-asher
left a comment
There was a problem hiding this comment.
Nice I like this! I think there might be some types that also need to be updated, but CI should tell us more once it runs.
I wonder if we can be more descriptive than token. Maybe authorizationHeaderToken? Or...hmm should we make it a general headers property maybe?? Then users could add whatever headers they need.
patches/marketplace.diff
Outdated
|
|
||
|
|
||
| Index: code-server/lib/vscode/src/vs/platform/product/common/product.ts | ||
| Index: coder-code-server-fork/lib/vscode/src/vs/platform/product/common/product.ts |
There was a problem hiding this comment.
Could we revert all these path changes that rename code-server to coder-code-server-fork?
I guess we could be more descriptive and use |
code-asher
left a comment
code-asher
left a comment
There was a problem hiding this comment.
I have this suspicion that this is one of those things that ends up being replaced by a generic solution and then we are stuck maintaining the old thing forever hahaha but this is tiny enough that it should be no problem to deprecate in the future if necessary. We have no idea if we really need a generic solution anyway, maybe this will be the only header we need.
Thanks again!
2 participants
…l extension marketplace
Fixes #7595